GitFOSS

@@ -14,7 +14,6 @@ const getLoginView: ReqHandler = (request, reply) => {
     // ! - [ ] check that path belongs to a registered route (how?)
     // ! - [ ] **do not** honour requests when both conditions ^ are not met
 
-    console.log("after_login_goto:", after_login_goto);
     request.session.data.auth_redirect_to = after_login_goto;
   }
 

@@ -75,7 +75,7 @@ const postLoginAction: ReqHandler = async (request, reply) => {
   // In case a redirect to url is set in session, go there.
   const authRedirectToUrl = request.session.data.auth_redirect_to;
   if (authRedirectToUrl != null) {
-    console.log("Will redirect back to before-auth uri.", authRedirectToUrl);
+    console.log("Will redirect back after login to uri:", authRedirectToUrl);
     request.session.data.auth_redirect_to = null; // prevent replay attack
     reply.redirect(302, authRedirectToUrl);
     return reply;

@@ -5,7 +5,6 @@ import { ReqHandler } from "@ethicdevs/react-monolith";
 import type { RepositoryWithParentAndForkedFromRepos } from "../../types";
 import { AppRoute, AppRouteParams } from "../../routes.defs";
 import { Const } from "../../const";
-import { buildRouteLink } from "../../utils/shared";
 // app services
 import { makeOrganizationService } from "../../services/organization";
 import { makeRepositoryService } from "../../services/repository";

@@ -35,23 +34,7 @@ const getRepositoryPullRequestCreateView: ReqHandler = async (
     request.session.data.authenticated === false ||
     request.session.data.curr_user_uid == null
   ) {
-    const getBackHereLink = buildRouteLink(
-      AppRoute.REPOSITORY_PULL_REQUEST_CREATE,
-      {
-        orgSlug,
-        repoSlug,
-      }
-    );
-
-    const redirectUrl = [
-      request.namedViewsPathMap[AppRoute.AUTH_LOGIN],
-      `?after_login_goto=${getBackHereLink}`,
-    ];
-
-    console.log("getBackHereLink:", getBackHereLink);
-    console.log("redirectUrl:", redirectUrl);
-
-    reply.redirect(302, redirectUrl.join(""));
+    reply.redirect(302, request.namedViewsPathMap[AppRoute.AUTH_LOGIN]);
     return reply;
   }
 

@@ -23,9 +23,6 @@ export const authenticatedOrLogin =
         `?after_login_goto=${redirectGotoUri.join("/")}`,
       ].join("");
 
-      console.log("redirectTo:", redirectAuthUri);
-
-      // reply.redirect(302, request.namedViewsPathMap[AppRoute.AUTH_LOGIN]);
       reply.redirect(302, redirectAuthUri);
     }
   };